Test non-matching joins #1317
Merged
Test non-matching joins #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyst
force-pushed
the
test_nonmatching_joins
branch
from
402e487 to
4da8fc9
Compare
nalimilan
reviewed
Dec 13, 2017
test/join.jl
Outdated
| @test eltypes(join(l, r, on=:id, kind=:outer)) == [Int, Union{CS, Missing}, Union{CS, Missing}] | ||
|
|
||
| # joins by cid | ||
| @test join(l, r, on=:cid, kind=:inner) ≅ DataFrame(id=Int[], cid=similar(l[:cid], 0), id_1=similar(r[:cid], 0)) |
There was a problem hiding this comment.
Break line at 92 chars. Same elsewhere.
test/join.jl
Outdated
| @@ -465,4 +465,58 @@ module TestJoin | |||
| @test join(left, right, on = [:id => :ID, :sid => :SID], kind=:anti) == | |||
| DataFrame(id = 1:2, sid = string.(1:2)) | |||
| end | |||
|
|
|||
| @testset "joins with no matching rows" begin | |||
There was a problem hiding this comment.
"and CategoricalArray columns"?
alyst
force-pushed
the
test_nonmatching_joins
branch
2 times, most recently
from
1b2225d to
76a0b14
Compare
|
Should be possible to rebase & merge now. |
alyst
force-pushed
the
test_nonmatching_joins
branch
from
76a0b14 to
9cc7ca4
Compare
|
Thanks! Rebased |
|
Tests pass on v0.6, nighlies fail early in joins, so it's hard to say whether anything in the new tests needs fixing. |
alyst
force-pushed
the
test_nonmatching_joins
branch
from
9cc7ca4 to
afbf86b
Compare
test situations when there are no matching rows in the left and right frames
alyst
force-pushed
the
test_nonmatching_joins
branch
from
afbf86b to
4bced10
Compare
nalimilan
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests should fail until JuliaData/CategoricalArrays.jl#111 and #1316 are merged.