Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure due to calling pairs() on keyword arguments on Julia 0.6 #1329

Merged
merged 1 commit into from
Dec 23, 2017
Merged

Fix failure due to calling pairs() on keyword arguments on Julia 0.6 #1329

merged 1 commit into from
Dec 23, 2017

Conversation

nalimilan
Copy link
Member

Introduced by #1320.

This was referenced Dec 23, 2017
Merged
Closed
@bkamins
Copy link
Member

bkamins commented Dec 23, 2017

Looks OK (I do not know how to check the exact 0.7 version to condition on; the PR that introduced pairs is JuliaLang/julia#22907).
Checked that on 0.6.2 the change works.

The only thing we have is that in the other constructor we have pairs as argument name, which in 0.7 conflicts with function in Base. Probably this is not a top priority to change it.

@ararslan
Copy link
Member

I do not know how to check the exact 0.7 version to condition on

directions

@ararslan ararslan merged commit 4abe138 into master Dec 23, 2017
@ararslan ararslan deleted the nl/kwpairs branch December 23, 2017 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nalimilan @bkamins @ararslan