Proposal for gen and collapse
#2210
Conversation
|
OK - I treat it as a reference to a discussion. This PR should not be merged and will be closed when #2206 is resolved. |
|
I will update this PR as consensus develops. When we all agree we can implement it for real. |
|
OK, but as @nalimilan commented in #2206 I do not expect that we will allow to define so many functions in DataFrames.jl. We will rather keep a minimal list of functions that cover all required functionality. The functions you propose are good for an extension package to DataFrames.jl so that users can opt-in to use them. |
| @@ -0,0 +1,46 @@ | |||
| function gen(df::AbstractDataFrame, args...; kwargs...) | |||
| transform(df, args...; kwargs...) | |||
There was a problem hiding this comment.
first small note (just for the future discussions) - this is not a correct implementation as args could overwrite all source columns of df.
src/gen_proposal.jl
Outdated
| end | ||
|
|
||
| function keep(df::AbstractDataFrame, args...; kwargs...) | ||
| t = gensym() |
There was a problem hiding this comment.
a second small note gensym() cannot be used here as it does not guarantee we will not have column name conflicts. But again - as above this is a minor issue than can be fixed.
|
I am closing this as 0.21 was released. If you decide to put these definitions in some accompanying package ping me and I can help with the review. Thank you for working on this! |
This is a very naive implementation of @bkamins 's plan for
collapse, etc. described here.Please keep comments focused on #2206. This is just to demonstrate how I imagine this should work.