Fix tests and deprecation warnings #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the updates, @nalimilan! As far as compatibility, I prefer the Compat.jl option. |
Using 'call' as a variable name currently triggers a bug in Julia 0.4: JuliaLang/julia#11295 Work around it for now by using a different name. Also get rid of deprecation warnings printed during the tests, using Compat.jl where necessary.
|
OK, I've added |
tshort
added a commit
that referenced
this pull request
May 17, 2015
Fix tests and deprecation warnings
|
Thanks again, @nalimilan. |
|
You're welcome. Should a new release be tagged? |
|
Yes. Good point.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 'call' as a variable name currently triggers a bug in
Julia 0.4: JuliaLang/julia#11295
Work around it for now by using a different name.
Also get rid of deprecation warnings printed during the tests.
This PR currently breaks compatibility with 0.3. Should I use Compat.jl, or do you prefer creating a new branch for 0.4?