Change @transform on a grouped dataframe to match DataFrames.transform
#180
Conversation
|
Not sure why the travis build is stalled. But this passes tests locally. I will merge after 1 approval since it's a small change that has a consensus. I'm not adding docs yet because the docs need a big re-write and the docus don't currently mention this particular feature. |
|
CI was stalled, because yesterday we had contributors who pushed many small commits to JuliaData - and this is a highly problematic situation (especially if these are commits to DataFrames.jl, whose CI lasts ~1h per commit). |
test/grouping.jl
Outdated
|
|
||
| d = DataFrame(a = [1,1,1,2,2,3,3,1], | ||
| b = Any[1,2,3,missing,missing,6.0,5.0,4], | ||
| c = CategoricalArray([1,2,3,1,2,3,1,2])) | ||
| g = groupby(d, :a) | ||
| g = groupby(d, :a) |
There was a problem hiding this comment.
Indentation seems to be incorrect here and in a few other places.
There was a problem hiding this comment.
indendation looks correct locally. I think github is displaying things weirdly.
There was a problem hiding this comment.
Looks like the rest of the file uses tabs. Better use tabs too, and fix the whole file later.
There was a problem hiding this comment.
Should be fixed now. Thanks for finding that.
News.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| # DataFramesMeta v0.6 Release Notes | |||
There was a problem hiding this comment.
Isn't it more common to call this file NEWS.md in uppercase?
News.md
Outdated
| order of rows returned after `DataFrames.transform(gd::GroupedDataFrame, args...)`. | ||
| `@select` now supports `GroupedDataFrame` ([#180]) |
There was a problem hiding this comment.
| order of rows returned after `DataFrames.transform(gd::GroupedDataFrame, args...)`. | |
| `@select` now supports `GroupedDataFrame` ([#180]) | |
| order of rows returned after `DataFrames.transform(gd::GroupedDataFrame, args...)`. | |
| `@select` now supports `GroupedDataFrame` ([#180]) |
(I think)
There was a problem hiding this comment.
Added a new bullet for @select, indentation as requested.
also add tests for
@select, which already worked after #163Closes #176 and superscedes #178