Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cols select fix #224

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Cols select fix #224

merged 3 commits into from
Mar 1, 2021

Conversation

pdeffebach
Copy link
Collaborator

Fixes #223

@pdeffebach
Copy link
Collaborator Author

pinging @bkamins or @nalimilan for an approval.

This is a bug fix, so one approval and I will merge.

I am a bit unhappy that there are so many if-else statements here. Maybe we can do a big refactor after #207

@pdeffebach pdeffebach merged commit 1076ec5 into JuliaData:master Mar 1, 2021
@pdeffebach
Copy link
Collaborator Author

Thanks!

@pdeffebach pdeffebach mentioned this pull request Mar 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@select(df, cols("X") failes
2 participants
@pdeffebach @bkamins