Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version, allow Reexport 1+ and DataFrames 1+ #241

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

raphaelsaavedra
Copy link
Contributor

@raphaelsaavedra raphaelsaavedra commented Apr 20, 2021

Closes #240.
Closes #237.

I did a minor version bump – let me know if there have been any breaking changes in master so I can fix it.

@pdeffebach
Copy link
Collaborator

Looking through PRs, the only changes to the API are

  1. allowing @select(df, cols(:a))
  2. adding @select! and @transform!

These were all errors before, so I think this means we can do 0.6.1? cc @bkamins

@bkamins
Copy link
Member

bkamins commented Apr 20, 2021

Yes, but in line 10 (https://github.com/JuliaData/DataFramesMeta.jl/pull/241/files#diff-72ed386c2a0cd1d23c0968297e70023ed98c22490d146dd89fc91f48369bad4dR10) of [compat] section we should also allow for DataFrames.jl 1 version. Can this change please be added? Thank you!

@raphaelsaavedra raphaelsaavedra changed the title Bump version to allow Reexport 1+ Bump version, allow Reexport 1+ and DataFrames 1+ Apr 20, 2021
@pdeffebach
Copy link
Collaborator

Thanks for this!

I was going to wait a bit longer to make a release, but if we want reexport to be consistent, it's better to make a patch release now. I will work on a small write up of what's changed and post that somewhere.

@pdeffebach pdeffebach merged commit ce591cb into JuliaData:master Apr 20, 2021
@raphaelsaavedra raphaelsaavedra deleted the patch-1 branch April 20, 2021 17:08
@bkamins
Copy link
Member

bkamins commented Apr 21, 2021

@pdeffebach - OK to make 0.6.1 release, because I see you have merged the PR but not made the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Reexport 1.0 Update version and release after DataFrames.jl 1.0 release
3 participants