-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cols to dollar #266
Cols to dollar #266
Conversation
Okay tests pass, so this is ready for a review. There are two problems that I am fine resolving later, after this is merged.
But you can't do the same in DataFramesMeta.jl. This is not a big deal, I guess. You can't have We should still merge, though. |
Do you know if the same issues with |
The same issues exist with DataFrameMacros.jl. I've spoken to @jkrumbiegel and he's fine with not working with every use-case of It's probably something we can iterate on at a later date, possibly through nesting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor comment. The issues you mentioned are annoying, it would be nice to find a way to escape/protect $
from other macros so that we don't have to keep cols
forever.
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Yes. I don't have any ideas on how to do that at the moment, but I will ask people who are more experienced in metaprogramming. Maybe John Myles White can return to his roots and help DataFramesMeta.jl again. |
Actually John hasn't contributed to this package at all. It was created by Tom Short. |
Ah sorry! I got my packages confused. I'm going to merge! This will create merge conflicts I will have to sort out in #267 |
With this PR, we no longer have
@transform df :y = f(cols("x"))
, but rather@transform df :y = f($"x")
.