-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow AsTable on RHS in transformations #307
Conversation
What would be the test cases for this? |
a row-wise sum
|
Nice - probably documentation should be updated (or does it already have it?) |
No I haven't done any of that yet. I'll ping you when its ready. |
Okay I've added enough stuff so that you can see the API
|
Okay ready for a review @bkamins @nalimilan If only to check if the API makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few stylistic comments.
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Thanks for the review! I have addressed all comments. I also got rid of the code example in the table because I couldn't figure out a way to get it to work. I think this is ready to merge? |
Looks good. I made some cosmetic comments. |
@@ -525,11 +525,165 @@ To reference columns with more complicated expressions, you must wrap column ref | |||
@transform df :a + $(get_column_name(x)) | |||
``` | |||
|
|||
## Constructing multi-column arguments and `src => fun => dest` calls using `$` | |||
## Operations with multiple columns at once using `AsTable` inside operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, why not put this section right after the one about @astable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Re-arranged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. I addressed all comments.
@@ -525,11 +525,165 @@ To reference columns with more complicated expressions, you must wrap column ref | |||
@transform df :a + $(get_column_name(x)) | |||
``` | |||
|
|||
## Constructing multi-column arguments and `src => fun => dest` calls using `$` | |||
## Operations with multiple columns at once using `AsTable` inside operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Re-arranged.
Co-authored-by: Bogumił Kamiński <bkamins@sgh.waw.pl> Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay ready for review / merging.
I went through the comments and resolved all that I thought were addressed. I left one related to indentation (a minor issue) + one regarding the order of presentation of things (so that @nalimilan can check if now we have what he wants). Thank you for working on thins! |
Awesome! Thanks for all the hard work reviewing this. |
After the recent improvements to
AsTable
in DataFrames, I guess it's time to make it easier to work with this construct in DataFramesMeta.jl.No tests added yet.