-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ready examples to docstring for rselect, rtransform (#321) #322
add ready examples to docstring for rselect, rtransform (#321) #322
Conversation
There was a doctest failure in my macro examples for @rtransform, and also @rselect. I'm not sure how this works so not able to determine what is missing. The dataframe operations are correct in project REPL, I must be missing some syntax in the docsstring? |
Probably |
Now I see. The other
@pdeffebach I will push another commit and try to update the PR or file a new one. Alternately, I could make @bkamins suggested change to I think @bkamins is saying that the following added to the DocMeta.setdocmeta!(DataFramesMeta, :DocTestSetup, :(using DataFramesMeta); recursive=true) Following the DataFrames.jl/doc/make.jl file. |
Yes, this is how we do it in https://github.com/JuliaData/DataFrames.jl/blob/5233159d470c8e5a9a2e2f93cd3ea67a7fff1769/docs/make.jl#L5. |
Yes we should definitely fix that. But just do the |
Thanks a ton for this! Do you think you could add these for |
Very happy to. I'll commit those in the same branch, for this PR. |
added minor change to df output. |
Let me know if there are needed changes before running the workflow tests. |
Sorry about the delay on this! Will merge tomorrow |
Thanks! Sorry about the delay. |
Awesome, ping me if you need some other help! |
I added REPL jldoctest examples for the
@rselect
and@rtransform
macros to demonstrate the easy syntax for operations that need a ByRow treatment.I choose these examples to show an easy way to post a value to a new column based on the row value in another column or combination of columns.