Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecations #195

Merged
merged 4 commits into from
Nov 22, 2018
Merged

remove deprecations #195

merged 4 commits into from
Nov 22, 2018

Conversation

joshday
Copy link
Collaborator

@joshday joshday commented Nov 21, 2018

Removing deprecations that have been around for a year and many releases

@piever
Copy link
Collaborator

piever commented Nov 21, 2018

Could you also add IndexedTable as a synonym for NextTable (I think that was the original plan)? Or you think this should be done in a future PR?

@joshday
Copy link
Collaborator Author

joshday commented Nov 21, 2018

Do you have a link to a conversation somewhere? The idea is to rename NextTable to IndexedTable?

One of the lines this PR removes is

Base.@deprecate_binding IndexedTable NDSparse

although IndexedTable isn't exported.

@piever
Copy link
Collaborator

piever commented Nov 21, 2018

IndexedTable used to be what is now NDSparse and it was the only table type offered here. Then @shashi had the idea to create a table where some columns are sorted and to call this IndexedTable instead. However, not to subtly change meaning of the word, IndexedTable was deprecated and the thing was called NextTable instead. Now it's probably a safe time to bring IndexedTable back to the intended meaning. The design of the API is discussed in JuliaData/JuliaDB.jl#80 and implemented in #85

@joshday
Copy link
Collaborator Author

joshday commented Nov 22, 2018

Thanks for the links! Since this is ready to go I'm going to merge it, but that will be next on my list of things to do.

@joshday joshday merged commit ecb8a23 into master Nov 22, 2018
@joshday joshday deleted the jd/cleanup branch November 22, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants