-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look into promotion issue #23
Comments
@nalimilan @andreasnoack, do we still need some extra promote definitions in Nulls for DataArrays? |
Indeed, see https://github.com/JuliaStats/DataArrays.jl/pull/288/files#r141439438. I haven't tried defining more specific methods to fix the stack overflow. |
I think so. We still have the not too general definitions https://github.com/JuliaStats/DataArrays.jl/blob/8b9e89617ca3539440a9a1b2fc75fc44f86ec850/src/natype.jl#L41-L52. I tried to make some changes to Base's promotion mechanisms to handle these kinds of promotions but it is really brittle and I didn't manage to get it working. |
Fix #23 by defining a few more helper promote_rule definitions
JuliaStats/DataArrays.jl#280 (comment)
The text was updated successfully, but these errors were encountered: