Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into promotion issue #23

Closed
quinnj opened this issue Jul 31, 2017 · 3 comments
Closed

Look into promotion issue #23

quinnj opened this issue Jul 31, 2017 · 3 comments

Comments

@quinnj
Copy link
Member

quinnj commented Jul 31, 2017

JuliaStats/DataArrays.jl#280 (comment)

@quinnj
Copy link
Member Author

quinnj commented Sep 27, 2017

@nalimilan @andreasnoack, do we still need some extra promote definitions in Nulls for DataArrays?

@nalimilan
Copy link
Member

Indeed, see https://github.com/JuliaStats/DataArrays.jl/pull/288/files#r141439438. I haven't tried defining more specific methods to fix the stack overflow.

@andreasnoack
Copy link
Member

I think so. We still have the not too general definitions https://github.com/JuliaStats/DataArrays.jl/blob/8b9e89617ca3539440a9a1b2fc75fc44f86ec850/src/natype.jl#L41-L52. I tried to make some changes to Base's promotion mechanisms to handle these kinds of promotions but it is really brittle and I didn't manage to get it working.

@quinnj quinnj closed this as completed in #41 Oct 4, 2017
quinnj added a commit that referenced this issue Oct 4, 2017
Fix #23 by defining a few more helper promote_rule definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants