Fix allocatecolumn #298
Merged
Fix allocatecolumn #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
commented
Sep 16, 2022
Codecov ReportBase: 95.05% // Head: 95.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 95.05% 95.07% +0.02%
==========================================
Files 7 7
Lines 708 711 +3
==========================================
+ Hits 673 676 +3
Misses 35 35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bkamins
commented
Sep 17, 2022
quinnj
approved these changes
Sep 17, 2022
|
Thank you! Can we have a patch release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for the fix is that old code:
Anyusedundefbranch (which most of the time works, but it is not guaranteed)undef(e.g. this is the case forCategoricalArray)What I propose is a safe approach, but maybe there would be better ideas.
x-ref: massive errors in DataFrames.jl JuliaData/DataFrames.jl#3158
CC @quinnj @nalimilan