Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #33 and another netcdf-related bug #57

Merged
merged 1 commit into from
May 5, 2021
Merged

Fix #33 and another netcdf-related bug #57

merged 1 commit into from
May 5, 2021

Conversation

meggart
Copy link
Member

@meggart meggart commented May 5, 2021

This fixes #33 and another bug which led to an error when trying to save a cube that had non-standard string types (like Zarr.MaxLengthString) in it axes. I can't remember the issue right now, a hint by @noralinscheid or @felixcremer would be great

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #57 (e3f50a8) into master (107996c) will increase coverage by 0.44%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   55.12%   55.56%   +0.44%     
==========================================
  Files          13       13              
  Lines        1531     1544      +13     
==========================================
+ Hits          844      858      +14     
+ Misses        687      686       -1     
Impacted Files Coverage Δ
src/DatasetAPI/Datasets.jl 69.62% <93.33%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 107996c...e3f50a8. Read the comment docs.

@coveralls
Copy link

coveralls commented May 5, 2021

Pull Request Test Coverage Report for Build 812832324

  • 14 of 15 (93.33%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 55.476%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DatasetAPI/Datasets.jl 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
src/DatasetAPI/Datasets.jl 1 69.28%
Totals Coverage Status
Change from base Build 773593482: 0.3%
Covered Lines: 856
Relevant Lines: 1543

💛 - Coveralls

@meggart meggart merged commit 4de682d into master May 5, 2021
@felixcremer
Copy link
Member

This was in #23 here and issue 3 in YaxarrayBase.

@meggart meggart deleted the fit_ncaxisbugs branch February 28, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving to NetCDF converts RangeAxis of Ints to RangeAxis of Floats
3 participants