Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a return code check when we're fetching results. Previously, ther… #246

Merged
merged 3 commits into from
Aug 7, 2019

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Aug 7, 2019

…e might have been an error when calling SQLFetchScroll and ODBC.jl ignored it

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #246 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage    48.2%   48.07%   -0.13%     
==========================================
  Files           6        6              
  Lines         417      416       -1     
==========================================
- Hits          201      200       -1     
  Misses        216      216
Impacted Files Coverage Δ
src/ODBC.jl 76.11% <100%> (ø) ⬆️
src/Query.jl 63.49% <100%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd9417...cf313d9. Read the comment docs.

@quinnj quinnj merged commit d2f2f4e into master Aug 7, 2019
@quinnj quinnj deleted the jq/resulterror branch August 7, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants