Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query perf when there are lots of nullable columns. Fixes #343 fr… #349

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Fix query perf when there are lots of nullable columns. Fixes #343 fr… #349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c90f152
Fix query perf when there are lots of nullable columns. Fixes #343 fr…
quinnj Aug 11, 2022
6bbad72
Merge branch 'main' into jq/metaperf
quinnj Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dbinterface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ function Cursor(stmt; iterate_rows::Bool=false, ignore_driver_row_count::Bool=fa
columnsizes[i] += 1
end
end
metadata = [["column name", names...] ["column type", types...] ["sql type", map(x->API.SQL_TYPES[x], sqltypes)...] ["c type", map(x->API.C_TYPES[x], ctypes)...] ["sizes", map(Int, columnsizes)...] ["nullable", map(x->x != API.SQL_NO_NULLS, nullables)...] ["long data", longtexts...]]
metadata = [Any["column name", names...] Any["column type", types...] Any["sql type", map(x->API.SQL_TYPES[x], sqltypes)...] Any["c type", map(x->API.C_TYPES[x], ctypes)...] Any["sizes", map(Int, columnsizes)...] Any["nullable", map(x->x != API.SQL_NO_NULLS, nullables)...] Any["long data", longtexts...]]
columnar = knownlength = true
if any(longtexts) || rows <= 0 || iterate_rows || ignore_driver_row_count
rowset = 1
Expand Down