Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an easy abstract type interface #22

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Add an easy abstract type interface #22

merged 2 commits into from
Dec 4, 2022

Conversation

Keno
Copy link
Member

@Keno Keno commented Dec 2, 2022

Can be used in place of the macro to give a pass CassetteoOverlay behavior. The abstract type works by reading the appropriate binding from the type parameter.

Requires JuliaLang/julia#47749

@Keno Keno requested a review from aviatesk December 2, 2022 03:54
Can be used in place of the macro to give a pass CassetteoOverlay
behavior. The abstract type works by reading the appropriate binding
from the type parameter.

Requires JuliaLang/julia#47749
Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if I understand correctly, we won't need this if we allow @generated to specify generation world age?
I agree with that #47749 seems to be simple so we may want to merge this in first though.

@Keno
Copy link
Member Author

Keno commented Dec 2, 2022

LGTM, but if I understand correctly, we won't need this if we allow @generated to specify generation world age?

Meh, it'd still be useful, but yes, it's partially a workaround for that.

@aviatesk
Copy link
Member

aviatesk commented Dec 2, 2022

Yeah, #47749 would be useful itself. Let's merge this PR once we get the base PR.

@Keno Keno merged commit f06b2e3 into master Dec 4, 2022
@aviatesk aviatesk deleted the kf/abstract branch December 5, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants