Add Julia 1.7 to test matrix #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project.toml claims we support 1.7; given how closely this package follows Julia development, that's a dangerous claim if it's not tested.
vchuravy
approved these changes
Mar 5, 2023
|
As I feared, on Julia 1.7 there's no e0789fa changed the CI line from '1' to '1.8'; that might mean it was broken before that. I'm guessing it was broken in 6a5a21b (#319, CC @ianatol), but obviously only because CI.yml was not explicit about what '1' meant. |
|
OK, I just skipped over the failing tests (they seem like missing functionality rather than correctness bugs). To me this seems OK, so I'll go ahead and merge and then re-run #356. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project.toml claims we support 1.7; given how closely this package
follows Julia development, that's a dangerous claim if it's not tested.