-
Notifications
You must be signed in to change notification settings - Fork 37
Create a "junk yard" even for Frames #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
=========================================
+ Coverage 88.17% 88.5% +0.33%
=========================================
Files 11 11
Lines 1742 1766 +24
=========================================
+ Hits 1536 1563 +27
+ Misses 206 203 -3
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
=========================================
+ Coverage 88.17% 88.5% +0.33%
=========================================
Files 11 11
Lines 1742 1766 +24
=========================================
+ Hits 1536 1563 +27
+ Misses 206 203 -3
Continue to review full report at Codecov.
|
|
Oh, interesting. Yes, I guess if we speed up the rest, this becomes important. |
|
It might improve GC times since we have a lot fewer objects to track as well. But for now, it doesn't seem like that big of a deal. |
|
I'm guessing the "one long vector" for all slots & ssavalues might supplant the need for this? It would also solve another problem: currently the caller packs the args into a vector, and then when you switch to the new frame they get copied again into the frame's slots. If we had one long vector, we could pack the args into it and thus do it only once. |
0595137 to
6279015
Compare
…hem over and over
6279015 to
da20b78
Compare
This avoids creating all the tiny
Frameobjects over and over.Running the tight loop benchmark:
The time difference is not that big but the allocations are only 75% and it is possible this will start to matter more when other things are more optimized.