Skip to content

Conversation

timholy
Copy link
Member

@timholy timholy commented May 1, 2020

There are a couple of changes to lowering that recently crept in. There may be more coming, since Revise's signature tests are completely busted and I haven't yet figured out which package needs to be fixed.

format = Documenter.HTML(prettyurls = get(ENV, "CI", nothing) == "true"),
sitename = "JuliaInterpreter.jl",
authors = "Keno Fischer, Tim Holy, and others",
authors = "Keno Fischer, Tim Holy, Kristoffer Carlsson, and others",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woho 🎉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't even know if this field does anything. But clearly we haven't maintained the docs in a long time!

@timholy timholy merged commit 568e5b7 into master May 1, 2020
@timholy timholy deleted the teh/juliamaster branch May 1, 2020 17:41
@timholy
Copy link
Member Author

timholy commented May 1, 2020

There will be more changes in LoweredCodeUtils & Revise, but it seems these were all we needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants