Adjust to upcoming compiler change #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `.inferred` field is being removed in [1], so delete the assertion. [1] JuliaLang/julia#53219
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
==========================================
- Coverage 85.06% 82.77% -2.30%
==========================================
Files 12 12
Lines 2537 2397 -140
==========================================
- Hits 2158 1984 -174
- Misses 379 413 +34 ☔ View full report in Codecov by Sentry. |
aviatesk
reviewed
Feb 22, 2024
| @@ -68,7 +68,6 @@ function optimize!(code::CodeInfo, scope) | |||
| mod = moduleof(scope) | |||
| evalmod = mod == Core.Compiler ? Core.Compiler : CompiledCalls | |||
| sparams = scope isa Method ? sparam_syms(scope) : Symbol[] | |||
| code.inferred && error("optimization of inferred code not implemented") | |||
There was a problem hiding this comment.
I wondered if we can replace the condition of this assertion with this one:
code.slottypes !== nothing && error("optimization of inferred code not implemented")There was a problem hiding this comment.
And the same for LoweredCodeUtils.jl too.
aviatesk
referenced
this pull request
in JuliaLang/julia
Feb 27, 2024
When we use options like code coverage, we can't use the native code present in the cache file since it is not instrumented. PR #52123 introduced the capability of skipping the native code during loading, but created the issue that subsequent packages could have an explicit or implicit dependency on the native code. PR #53439 tainted the current process by setting `use_sysimage_native_code`, but this flag is propagated to subprocesses and lead to a regression in test time. Move this to a process local flag to avoid the regression. In the future we might be able to change the calling convention for cross-image calls to `invoke(ci::CodeInstance, args...)` instead of `ci.fptr(args...)` to handle native code not being present. --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.inferredfield is being removed in [1], so delete the assertion.[1] JuliaLang/julia#53219