minor inferrability tweaks #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 5 5
Lines 970 970
=======================================
Hits 898 898
Misses 72 72
Continue to review full report at Codecov.
|
- `@isssa`/`@isslotnum` hacks circumvent JuliaLang/julia#37342 and gets rid of type assertions and accompanying inference overheads (I left type assertions themselves though, in order to make them work in older versions of Julia) NOTE: well, we won't need them once JuliaLang/julia#38905 gets merged - improve inferrability around `pcexec` within `selective_eval!`
aviatesk
force-pushed
the
inferrabilitynerd
branch
from
2d1dad1 to
3d6c2db
Compare
timholy
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@isssa/@isslotnumhacks circumvent Type check in callee does not propagate to caller JuliaLang/julia#37342and get rid of type assertions and accompanying inference overheads
(I left type assertions themselves though, in order to make them work
in older versions of Julia)
NOTE: in future versions, we won't need them once inference: inter-procedural conditional constraint back-propagation JuliaLang/julia#38905
gets merged
pcexecwithinselective_eval!