Skip to content

Remove cruft #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 18, 2024
Merged

Remove cruft #384

merged 10 commits into from
Apr 18, 2024

Conversation

@timholy
Copy link
Member

@timholy timholy commented Apr 16, 2024 •
edited
Loading

This certainly isn't complete (e.g., the documentation will be updated separately), but it's a big chunk of #382:

  • officially bump the version to 3.0.0
  • require a minimum of Julia 1.10
  • eliminate SnoopPrecompile
  • delete a lot of version-specific cruft
  • add two new extensions
  • remove dependency on Requires

This was referenced Apr 16, 2024
Closed
Open
@timholy
Copy link
Member Author

timholy commented Apr 16, 2024

I don't think this needs a detailed review, but I'd appreciate whether the general plan meets approval @aviatesk @mkitti

mkitti
mkitti approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@mkitti mkitti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave some additional breadcrumbs about the changes and the removed features and packages.

aviatesk
aviatesk approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see old code removed! I think we probably want to rename @snoopi_deep to @snoopi, while also deprecating @snoopi_deep and making it an alias for the new @snoopi?

@timholy
Copy link
Member Author

timholy commented Apr 17, 2024

How about a more wholesale renaming?

  • @snoopi_deep -> @snoop_infer
  • @snoopl -> @snoop_llvm
  • @snoopr -> @snoop_inval

@aviatesk
Copy link
Member

aviatesk commented Apr 17, 2024

How about a more wholesale renaming?

  • @snoopi_deep -> @snoop_infer
  • @snoopl -> @snoop_llvm
  • @snoopr -> @snoop_inval

That sounds good to me. I'm all for that.

@timholy
Copy link
Member Author

timholy commented Apr 18, 2024

Further changes, like renaming the main data-collection macros, are things I intend for a future PR.

@timholy timholy merged commit 3de7217 into master Apr 18, 2024
@timholy timholy deleted the teh/delete_cruft branch April 18, 2024 19:40
@kimikage kimikage mentioned this pull request Apr 24, 2024
Closed
@ararslan ararslan mentioned this pull request Feb 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aviatesk aviatesk aviatesk approved these changes

+1 more reviewer

@mkitti mkitti mkitti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timholy @aviatesk @mkitti