Add docs for isprecompilable
#416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also enhances its implementation to make it more flexible. Closes #411
Comment on lines
+274
to
+275
| If `mi` has been compiled by the time its defining module "closes" (the final | ||
| `end` of the module definition) and `isprecompilable(mi)` returns `true`, then |
There was a problem hiding this comment.
If
mihas been compiled by the time its defining module "closes" (the final
endof the module definition)
When might this happen? Would it mean that the defining module would need to call mi?
There was a problem hiding this comment.
If mi corresponds to f(x), then just calling f(x) before the module closes will do it. For the inferrable callees of this method, it won't matter if it's inside or outside a @compile_workload block. For any runtime-dispatched ones, it will matter a lot. But if you're thinking about a single "flame" on the flamegraph, that's irrelevant, because one flame = the inferrable callees of the entrypoint (base of the flame).
charleskawczynski
approved these changes
Mar 25, 2025
Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also enhances its implementation to make it more flexible.
Closes #411