-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement backend for Tracker #44
Conversation
Tracker's an interesting case because I think you want to avoid calling |
Actually, even if we track nesting in the constructor, we still have the problem that the test suite uses |
These aren't necessary to pass first-order tests
struct TrackerBackend <: AbstractReverseMode end | ||
|
||
function second_lowest(::TrackerBackend) | ||
return throw(ArgumentError("Tracker backend does not support nested differentiation.")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the best way I could think of to signal that Tracker should not be used for higher order AD.
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 82.39% 83.00% +0.61%
==========================================
Files 4 5 +1
Lines 443 459 +16
==========================================
+ Hits 365 381 +16
Misses 78 78
Continue to review full report at Codecov.
|
This PR is now ready for review. Our version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks Seth and sorry for the delay. |
Relates #40