Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop SpecialFunctions dependency #319

Closed
stevengj opened this issue Dec 4, 2020 · 2 comments · Fixed by #425
Closed

Drop SpecialFunctions dependency #319

stevengj opened this issue Dec 4, 2020 · 2 comments · Fixed by #425

Comments

@stevengj
Copy link
Contributor

stevengj commented Dec 4, 2020 •
edited
Loading

The next release of SpecialFunctions will include ChainRulesCore rules: JuliaMath/SpecialFunctions.jl#238

Do we need to synchronize releases to prevent Julia from complaining about overwritten method definitions? That is, once we update SpecialFunctions, do a new release of ChainRules shortly afterwards?

cc @devmotion
This was referenced Dec 4, 2020
Closed
Closed
@devmotion
Copy link
Member

One could follow @oxinabox's suggestion in JuliaMath/SpecialFunctions.jl#238 (comment) and introduce a check in ChainRules and releasing it before the next release of SpecialFunctions.

@devmotion devmotion mentioned this issue Dec 4, 2020
Merged
@oxinabox
Copy link
Member

oxinabox commented Dec 4, 2020

We should do that then next breaking release of ChainRules.jl drop the dependency and the rules.

This was referenced Jun 1, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@devmotion @stevengj @oxinabox