Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove NanMath and SpecialFunctions.jl #425

Merged
merged 1 commit into from
Jun 2, 2021
Merged

remove NanMath and SpecialFunctions.jl #425

merged 1 commit into from
Jun 2, 2021

Conversation

mzgubic
Copy link
Member

@mzgubic mzgubic commented Jun 1, 2021

Closes #319, closes #142 , closes #280, closes #402, relevant for #206 and #292

To be merged after #417 in the same breaking release.

To avoid a rebase, just cherry pick the commit in #423

@github-actions github-actions bot added the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Jun 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #425 (f0ec065) into master (b48b89d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   98.41%   98.38%   -0.03%     
==========================================
  Files          23       21       -2     
  Lines        2020     1984      -36     
==========================================
- Hits         1988     1952      -36     
  Misses         32       32              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48b89d...f0ec065. Read the comment docs.

@nickrobinson251
Copy link
Contributor

there may be some stuff related in the docs we want to tidy up e.g. https://juliadiff.org/ChainRulesCore.jl/dev/FAQ.html#Where-should-I-put-my-rules? (but ofc that's a CRCore PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs version bump Version needs to be incremented or set to -DEV in Project.toml
Projects
None yet
4 participants