Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MersenneTwister #223

Merged
merged 5 commits into from
Jul 5, 2020
Merged

MersenneTwister #223

merged 5 commits into from
Jul 5, 2020

Conversation

willtebbutt
Copy link
Member

Ideally this would be covered with a nograd macro along the lines of JuliaDiff/ChainRulesCore.jl#150. Unfortunately I've not implemented that feature yet, so here we are.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you don't want to implement that first and matching test utils for it?

@willtebbutt
Copy link
Member Author

Are you sure you don't want to implement that first and matching test utils for it?

No, but I've done this now. And this gives us a prime example of a no-grad-able thing to look at when someone (I'm thinking maybe @glennmoy ) gets around to implementing a no-grad thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants