WIP: Make getindex work for arrays with any eltype #290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split off ove #240
@willtebbutt said here #240 (comment)
Turns out this is much harder than i thought.
Finding zeros is annoying
Splitting it into its own PR so not to block other more important things
I think this is right but it could be better and also:
ChainRulesTestUtils freaks out at these tests.
I know one bit to fix it is to do
LinearAlgebra.norm(::Zero) = 0.0
I think another might be to stop using
isapprox
directly on arbitary typesOne thing that makes it a bit more annoying is:
JuliaLang/julia#38064