Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules for dense matrix exponential #351
Add rules for dense matrix exponential #351
Changes from 12 commits
6e8358c
f987f35
e6b92c9
7624ee5
a7792a5
6d6b4cb
3645d75
937f2ac
b48204c
2c19bba
58f6005
6ee1759
b1a2980
e860b3e
8f665ac
9e565ae
71134fd
bd48565
062b11d
dc1b1ab
57aea17
e2e6605
976af09
d7d20ba
b0ae61c
62b963b
87e4c53
9bd06b1
2ed06e6
156e6f5
9a63d13
5ba193d
49df929
8c27276
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that is hideous, but notation is hard, and harder in unicode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unicode's missing subscripts make it extra hard.
Idea that might not be worth doing:
What if we just made a section for this in the docs, (maybe as internal notes or something)
and wrote the latex and then linked to that?
But yeah notation for pullbacks and pushforwards is hard.
It has to convey so much state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit makes sense:
(f^*)_Y(ΔY) = ((f_*)_A(ΔY'))'
so the pullback at
A
, i.e. the pullback from Y (though that's not well defined since not all functions are monotonic?)is equal to the the adjoint of the pushing forward at
A
, the adjoint of of the output senstivity.the fact that that is also equal to
(f_*)_{A'}(ΔY)
is pretty magic.Magical expodential symmetry? (I feel like i made the same suprised sounds for the same reason on your last PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, that's an idea. I'll consider it, potentially for a future PR.
Ah yes your description is correct (although it's the adjoint of the pushing forward of the adjoint). I just checked Lee, and this should be the right notation:
I'm not sure what you mean by this.
It's still surprising to me. Although this property is general for all of the matrix functions defined in LinearAlgebra, not just
exp
. It doesn't follow for all matrix functions though, just those whose convergent power series have real coefficients.