-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Array rules #491
Merged
Merged
Some Array rules #491
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7481f55
Bump minor version
willtebbutt 1802186
Add undef Array constructor
willtebbutt 880c50f
construct Array from existing AbstractArray
willtebbutt 7a0375c
vect implementation
willtebbutt 5c061fb
Bump precision
willtebbutt 21b6bed
Additional tests
willtebbutt b669b35
Merge branch 'wct/some-rules' of https://github.com/JuliaDiff/ChainRu…
willtebbutt 1a0ead2
Fix undef tests
willtebbutt cac5b4f
Constraint vect implementation
willtebbutt 0d18c81
Add float-only test
willtebbutt 6564952
Link to non_differentiable tests issue
willtebbutt 060825a
Type-stable `vect` implementation
willtebbutt fca9087
type stable vect pullback
willtebbutt 641fabb
Merge in main
willtebbutt f9d22b6
Update src/rulesets/Base/array.jl
willtebbutt b3bf297
Test Union{Number, AbstractArray}
willtebbutt 5971c58
Don't test inference below 1.6
willtebbutt acd82e1
Update src/rulesets/Base/array.jl
willtebbutt 48e5a67
Update src/rulesets/Base/array.jl
willtebbutt a061b02
Style fix
willtebbutt f5bb4fc
Style fix
willtebbutt a3ebb8b
Update src/rulesets/Base/array.jl
willtebbutt ed60ed4
Style fix
willtebbutt 000b33f
Add an extra test
willtebbutt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering whether
projects[n]
gets handled well.@code_warntype
seems happy... and my attempts to make things easier to unroll all make it slower: