Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule for sum allowing 2nd derivatives #494

Merged
merged 4 commits into from
Aug 4, 2021

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Aug 3, 2021

Replaces #493 . Moves the same logic as before to a new (internal) function, for which additional rules are defined, to allow for higher-order derivatives. And inserts a few Ref to make this work for arrays of arrays.

Copy link
Contributor

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and passes the Diffractor test case, so 👍

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #494 (2ff02b6) into master (7593339) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   98.11%   98.12%           
=======================================
  Files          22       22           
  Lines        2340     2350   +10     
=======================================
+ Hits         2296     2306   +10     
  Misses         44       44           
Impacted Files Coverage Δ
src/rulesets/Base/nondiff.jl 100.00% <ø> (ø)
src/rulesets/Base/mapreduce.jl 99.12% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7593339...2ff02b6. Read the comment docs.

@mcabbott mcabbott merged commit 0d55c54 into JuliaDiff:master Aug 4, 2021
@mcabbott mcabbott deleted the sum_second branch August 4, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants