Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More vect #496

Merged
merged 10 commits into from
Aug 13, 2021
Merged

More vect #496

merged 10 commits into from
Aug 13, 2021

Conversation

willtebbutt
Copy link
Member

Finishes up some extra stuff from #492 -- as per @mcabbott 's suggestion, I've just added a generic method.

@willtebbutt willtebbutt mentioned this pull request Aug 10, 2021
Merged
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021 •
edited
Loading

Codecov Report

Merging #496 (fc51052) into master (0d55c54) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #496   +/-   ##
=======================================
  Coverage   98.12%   98.13%           
=======================================
  Files          22       22           
  Lines        2350     2353    +3     
=======================================
+ Hits         2306     2309    +3     
  Misses         44       44
Impacted Files Coverage Δ
src/rulesets/Base/array.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d55c54...fc51052. Read the comment docs.

@oxinabox oxinabox requested a review from mcabbott August 10, 2021 12:24
oxinabox
oxinabox approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, subject to my comment being correct.
if it is wrong then i need more info.

@oxinabox oxinabox removed the request for review from mcabbott August 10, 2021 12:30
willtebbutt and others added 3 commits August 10, 2021 13:50
@willtebbutt @mcabbott
Improve inferability
1827a1d 
Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
@willtebbutt @oxinabox
Improve comment
f246691 
Co-authored-by: Lyndon White <oxinabox@ucc.asn.au>
@willtebbutt
Update comment
fc51052
@willtebbutt
Copy link
Member Author

willtebbutt commented Aug 11, 2021 •
edited
Loading

@mcabbott @oxinabox comment updated. Please let me know if it's descriptive enough. It turned out to be easier to describe when the rule is correct, rather than incorrect.

@st-- st-- mentioned this pull request Aug 11, 2021
Merged
@github-actions github-actions bot added the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Aug 13, 2021
@github-actions github-actions bot removed the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Aug 13, 2021
@willtebbutt willtebbutt merged commit 262be3c into master Aug 13, 2021
@willtebbutt willtebbutt deleted the wct/vect branch August 13, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcabbott mcabbott mcabbott left review comments

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willtebbutt @codecov-commenter @oxinabox @mcabbott