Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DNE -> DoesNotExist #94

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Rename DNE -> DoesNotExist #94

merged 2 commits into from
Oct 28, 2019

Conversation

nickrobinson251
Copy link
Contributor

@nickrobinson251 nickrobinson251 commented Aug 30, 2019

@willtebbutt
Copy link
Member

I assume that the motivation for this is just that DNE isn't very readable if you don't know what's going on, whereas DoesNotExist is self explanatory?

@oxinabox
Copy link
Member

I am trying to decide if should release ChainRulesCore.jl v0.4.0
so that this can pass.

@nickrobinson251
Copy link
Contributor Author

I am trying to decide if should release ChainRulesCore.jl v0.4.0

contains some good stuff

@oxinabox
Copy link
Member

good point, releasing

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires breaking version bump, if tyhis is actually breaking

@oxinabox oxinabox dismissed their stale review October 28, 2019 17:36

nah is is not breaking

@oxinabox oxinabox merged commit 80de568 into master Oct 28, 2019
@nickrobinson251 nickrobinson251 deleted the npr/rename-dne-doesnotexit branch October 28, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants