-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make getproperty
on Composite
unthunk
#121
Conversation
nickrobinson251
commented
Jan 25, 2020
- closes getproperty on Composite should unthunk? #100
I think we should hold off on this until we see as case that someone actually uses thunking inside a a Composite with more than one fields (and thus can't move it to the outside). I suspect @willtebbutt already might have one. |
The rules |
|
Ah good point. I did thunk in forward mode in #JuliaDiff/ChainRules.jl#193, but I see I probably shouldn't. |
After seeing While it is reasonable for an AD to unthunk the things it passes into a pullback, Can you rebase this? |
7bd82b4
to
629cd3e
Compare
Integration test failure is from an assertion in the tests; which can just be removed. (Or replaces with something that accesses the We should make a follow up to remove that assertion, and maybe remove the rest of Are you able to make that PR after this is merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should getindex
and iterate
also be changed to unthunk
?
I think that would make sense since those are the otherways you can try and acces the content
I think yes. But i will open an issue / leave to a follow-up if that's okay? |