Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading zero(::DateTime) example #151

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

nickrobinson251
Copy link
Contributor

  • following Add zero for TimeType JuliaLang/julia#35554
    which agrees with the point made here, but shows the
    given code to be misleading.
  • i don't know if this is the best replacement text... maybe just delete that clause (since it is enough that DateTimes cannot be added to each other

- following JuliaLang/julia#35554
  which agrees with the point made here, but shows the
  given code to be misleading.
@willtebbutt
Copy link
Member

I think it's probably sufficient to say that you can't add them, as this presumably precludes the existence of an additive zero.

@nickrobinson251 nickrobinson251 merged commit fd6d0d9 into master Apr 27, 2020
@nickrobinson251 nickrobinson251 deleted the npr/design-nitpick branch April 27, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants