-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate NO_FIELDS
by NoTangent()
#358
Conversation
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 14 14
Lines 542 542
=======================================
Hits 470 470
Misses 72 72
Continue to review full report at Codecov.
|
I think it probably should be considered breaking. |
Do we still want to deprecate if it is a breaking change? Should we simply change it instead? |
I do want to deprecate it as a breaking change yes. |
Closes #175. Given the discussion in the issue I think we want to pretend that this is non-breaking?
Zero
andDoesNotExist()
behave similarly enough I suppose?