Deprecate extern #365
Deprecate extern #365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 89.26% 87.15% -2.11%
==========================================
Files 12 12
Lines 475 475
==========================================
- Hits 424 414 -10
- Misses 51 61 +10
Continue to review full report at Codecov.
|
| wrapped by `x`, such that mutating `extern(x)` might mutate `x` itself. | ||
| """ | ||
| @inline function extern(x) | ||
| Base.depwarn(EXTERN_DEPRECATION, :extern) |
There was a problem hiding this comment.
I thought I asked this before, but if so github has eaten the reply.
(Probably i forget to ask)
Why are we using Base.depwarn rather than @deprecate?
There was a problem hiding this comment.
Oh, I think it's because we are not providing a definite alternative. I.e. it isn't always just extern -> unthunk, it could be using backing as well
There was a problem hiding this comment.
In general we are not.
But for any specific case they can make the change to put the RHS of the deprecation in the place of the extern.
which they might have to do recursively til it stops but still.
Though perhaps that is worse.
Towards #56