Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ProjectTo implementation #387

Closed
wants to merge 28 commits into from
Closed

WIP: ProjectTo implementation #387

wants to merge 28 commits into from

Conversation

mzgubic
Copy link
Member

@mzgubic mzgubic commented Jun 30, 2021

Building on #385. Alternative to #380, #382 and #383. See usage in JuliaDiff/ChainRules.jl#459

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #387 (eefd84f) into master (653cd7d) will increase coverage by 0.15%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   89.20%   89.35%   +0.15%     
==========================================
  Files          14       15       +1     
  Lines         565      620      +55     
==========================================
+ Hits          504      554      +50     
- Misses         61       66       +5     
Impacted Files Coverage Δ
src/ChainRulesCore.jl 100.00% <ø> (ø)
src/differentials/composite.jl 82.90% <ø> (ø)
src/projection.jl 90.90% <90.90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653cd7d...eefd84f. Read the comment docs.

@mzgubic mzgubic closed this Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants