Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-constant f in Enzyme #309

Closed
wants to merge 1 commit into from
Closed

Non-constant f in Enzyme #309

wants to merge 1 commit into from

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jun 6, 2024

DI extensions

  • Remove Const annotation on f.
    • Downside: performance loss in most cases
    • Upside: allows closures and thus second order

DI tests

  • Test this

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 89.08%. Comparing base (0b7a2f9) to head (3364518).

Files Patch % Lines
...ifferentiationInterfaceEnzymeExt/reverse_onearg.jl 0.00% 7 Missing ⚠️
...ifferentiationInterfaceEnzymeExt/forward_onearg.jl 0.00% 2 Missing ⚠️
...ifferentiationInterfaceEnzymeExt/reverse_twoarg.jl 0.00% 2 Missing ⚠️
...ifferentiationInterfaceEnzymeExt/forward_twoarg.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   96.32%   89.08%   -7.24%     
==========================================
  Files          95       93       -2     
  Lines        4294     4262      -32     
==========================================
- Hits         4136     3797     -339     
- Misses        158      465     +307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle closed this Jun 6, 2024
@gdalle gdalle deleted the gd/non_constant_f_enzyme branch June 7, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enzyme hessian with closure: "You may be using a constant variable as temporary storage for active memory"
2 participants