-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-argument support: basic infrastructure #461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 98.53% 98.51% -0.03%
==========================================
Files 106 108 +2
Lines 4234 4297 +63
==========================================
+ Hits 4172 4233 +61
- Misses 62 64 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For some backends, users can now pass additional context arguments to differentiation operators, which are forwarded to the function. This helps avoid closures and tap into Enzyme's annotations more efficiently. See also #311 and #403 for discussions.
Note
This PR is not complete, see the follow up issues in #465 and #466.
The following rules apply:
x
, which is provided right after the backend. The number of context arguments is arbitrary:f(x)
becomesf(x, contexts...)
andf!(y, x)
becomesf!(y, x, contexts...)
.x
and not to the context arguments.Constant
is the only context type, but we will addCache
in the future.Example
Setup:
Right number of arguments:
Wrong number of arguments:
DI source
Context
abstract type with itsConstant
subtype. Addunwrap
andRewrap
to remove or recover wrapper types.gradient
orderivative
.DI extensions
DIT source
Scenario
.insert_context
to turnf(x)
intof(x, a) = a * f(x)
and insert that function in the scenario.DI and DIT tests