Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propagate src to cardtheme #134

Merged
merged 1 commit into from
Nov 27, 2022
Merged

propagate src to cardtheme #134

merged 1 commit into from
Nov 27, 2022

Conversation

t-bltg
Copy link
Collaborator

@t-bltg t-bltg commented Nov 26, 2022 •
edited
Loading

cardtheme should not try copy to a hardcoded "src" path, and should instead copy to the src path given to makedemos.

CI errors unrelated.
Needed for JuliaPlots/PlotDocs.jl#328.

@t-bltg
Copy link
Collaborator Author

t-bltg commented Nov 27, 2022 •
edited
Loading

Thanks @johnnychen94 for the invitation to contribute to this repo.

I will maybe try to fix windows ci if I have a few spare minutes ;)

Merging now ...

@t-bltg t-bltg merged commit 7115cd8 into JuliaDocs:master Nov 27, 2022
@t-bltg t-bltg deleted the theme branch November 27, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnychen94 johnnychen94 johnnychen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bltg @johnnychen94