Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version #141

Merged
merged 2 commits into from
Feb 11, 2023
Merged

bump version #141

merged 2 commits into from
Feb 11, 2023

Conversation

t-bltg
Copy link
Collaborator

@t-bltg t-bltg commented Feb 10, 2023 •
edited
Loading

Is everyone ok with a new version ?

It's debatable whether making Pluto optional requires a minor or patch bump, I'm ok with both.

Dsantra92
Dsantra92 requested changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@Dsantra92 Dsantra92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, should be at least a minor bump.

I was planning for a release after adding Pluto.jl tests. But tests are far from done and I am currently too occupied to work on that. So let's make a release now.

But there are some currently grammatical mistakes in the Pluto.jl docs. We will rebase and merge this pr after we fix the docs?

@t-bltg
Copy link
Collaborator Author

t-bltg commented Feb 10, 2023

Thanks for commenting.

But there are some currently grammatical mistakes in the Pluto.jl docs. We will rebase and merge this pr after we fix the docs?

What should be changed ?

@Dsantra92
Copy link
Collaborator

Dsantra92 commented Feb 10, 2023 •
edited
Loading

What should be changed ?

Merge after #142 ?

@Dsantra92
Copy link
Collaborator

LGTM from my end.

@t-bltg
Copy link
Collaborator Author

t-bltg commented Feb 10, 2023

Thanks for fixing the docs !

Maybe we should wait for @johnnychen94 approval ;)

@Dsantra92
Copy link
Collaborator

Dsantra92 commented Feb 10, 2023 •
edited
Loading

Maybe we should wait for @johnnychen94 approval ;)

Yes yes!

johnnychen94
johnnychen94 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge :)

I'm a bit inactive these days so please feel free to move on; I'll comment when I get a chance

@Dsantra92 Dsantra92 merged commit 22ba900 into master Feb 11, 2023
@t-bltg t-bltg deleted the t-bltg-patch-1 branch February 11, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnychen94 johnnychen94 johnnychen94 approved these changes

@Dsantra92 Dsantra92 Dsantra92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-bltg @Dsantra92 @johnnychen94