prepare for macrocall having a source location argument #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I'm not really familiar with the docsystem code -- this is an enhancement that will be available with 0.7 / master, right? |
vtjnash
force-pushed
the
jn/macro-sourcelocation
branch
from
234528d to
b0f0b22
Compare
|
Yes, this is for a PR against Julia master |
|
But 0.7 builds won't fail without this, right? I am wondering whether I should worry about backporting. |
|
They'll start to fail once JuliaLang/julia#21746 is merged, which is why this needed to be done first |
|
Ah, I'll tag a patch release for Documenter asap then. |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#21746
(will need JuliaLang/Compat.jl#355 to be merged and tagged first, then restart CI here)