Add capture_buffer option
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the same as #22, just as an officially documented feature |
This was referenced Jan 12, 2024
Closed
|
I'm fine with it just being an documented keyword like this. It's not really changing the complexity of the implementation much. |
|
I agree, I think this is perfectly fine to have as a proper feature, to give users a bit more power. Could we just have a few simple tests, preferably also one that interacts with #23, and a CHANGELOG note? |
|
Will do! Agreed on the test, so we should probably merge #23 first, and I'll rebase and adapt this PR, afterward. |
Giving a non-standard `capture_buffer` allows to dynamically process the captured output in arbitrary ways. For example, a custom buffer may discard part of some very large output. The object passed as `capture_buffer` must implement two methods: `Base.write(capture_buffer, bytes)` and `bytes = Base.take!(capture_buffer)`.
goerz
force-pushed
the
mg/capture-buffer
branch
from
09e69a1 to
6495de7
Compare
goerz
force-pushed
the
mg/capture-buffer
branch
from
97b174a to
e5dcd3d
Compare
goerz
force-pushed
the
mg/capture-buffer
branch
from
e5dcd3d to
c9db784
Compare
|
Ok, rebased, added test and documentation for how Should be good to go! |
mortenpi
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving a non-standard
capture_bufferallows to dynamically process the captured output in arbitrary ways. For example, a custom buffer may discard part of some very large output. The object passed ascapture_buffermust implement two methods:Base.write(capture_buffer, bytes)andbytes = Base.take!(capture_buffer).Closes #21