Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use broadcasting in SymbolicSpatialPermutation docstring example #130

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

kahaaga
Copy link
Member

@kahaaga kahaaga commented Oct 13, 2022

No description provided.

@kahaaga kahaaga changed the title Fixes #125 by avoiding the issue completely Don't use broadcasting in SymbolicSpatialPermutation Oct 13, 2022
@kahaaga kahaaga changed the title Don't use broadcasting in SymbolicSpatialPermutation Don't use broadcasting in SymbolicSpatialPermutation docstring example Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #130 (fd302e3) into main (5b1d4fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   78.27%   78.27%           
=======================================
  Files          30       30           
  Lines         718      718           
=======================================
  Hits          562      562           
  Misses        156      156           
Impacted Files Coverage Δ
...imators/permutation_ordinal/spatial_permutation.jl 91.30% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Datseris Datseris merged commit edce107 into main Oct 14, 2022
@Datseris Datseris deleted the symbolic_spatial_perm_docfix branch October 14, 2022 13:15
kahaaga added a commit that referenced this pull request Oct 22, 2022
Datseris added a commit that referenced this pull request Oct 23, 2022
* Sample entropy

* docstring

* Fix missing import and adjust figure

* Faster implementation and normalization

* Add NearestNeighbors to dependencies

* `SampleEntropy` estimator and convencience function `sample_entropy``

* Simplified and more performant algorithm

* Documentation and examples

* Adjust normalization

* Add "analytical" tests

* Use complexity API

* Constructors and typo

* Need access to estimator variables

* Show normalized sample entropy

* Test normalized version too

* Shorten comments, restructure and add error messages

* Error messages should occur generically

* Be specific that we only support vectors

* Docs

* More tests

* Better docstring

* Update src/complexity_measures/sample_entropy.jl

Co-authored-by: George Datseris <datseris.george@gmail.com>

* Address review comments


Add convenience method


Missing word


Address review comments


Improve syntax

* Add convencience wrapper, as agreed on in #130

* Double ## forces the header to appear in menu, like for entropy section

* Document convenience functions

* Test that error is thrown when not providing r

* Use new version from Neighborhood.jl

Co-authored-by: George Datseris <datseris.george@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants