-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complexity API #134
Complexity API #134
Changes from 5 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
# [Complexity measures](@id complexity_measures) | ||
# [Complexity API](@id complexity_measures) | ||
|
||
```@docs | ||
complexity | ||
complexity_normalized | ||
``` | ||
|
||
## Reverse dispersion entropy | ||
|
||
```@docs | ||
reverse_dispersion | ||
ReverseDispersion | ||
distance_to_whitenoise | ||
``` |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,36 @@ | ||||||
export ComplexityMeasure | ||||||
export complexity | ||||||
export complexity_normalized | ||||||
|
||||||
""" | ||||||
ComplexityMeasure | ||||||
|
||||||
Abstract type for (entropy-like) complexity measures. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
(that's how its typically called, see e.g. |
||||||
""" | ||||||
abstract type ComplexityMeasure end | ||||||
|
||||||
""" | ||||||
complexity(c::ComplexityMeasure, x) | ||||||
|
||||||
Estimate the complexity measure `c` for input data `x`, where `c` can be any of the | ||||||
following measures: | ||||||
|
||||||
- [`ReverseDispersion`](@ref). | ||||||
|
||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shall we add the standard 'see Input data for how Entropies.jl expects input types' here as well? Like in |
||||||
""" | ||||||
function complexity end | ||||||
|
||||||
""" | ||||||
complexity_normalized(c::ComplexityMeasure, x) → m ∈ [a, b] | ||||||
|
||||||
Estimate the normalized complexity measure `c` for input data `x`, where `c` can | ||||||
can be any of the following measures: | ||||||
|
||||||
- [`ReverseDispersion`](@ref). | ||||||
|
||||||
The potential range `[a, b]` of the output value depends on `c`. See the documentation | ||||||
strings for the individual measures to get the normalized ranges. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should avoid duplicate information here. We shouldn't list the available measures. Instead, cross reference I also am not sure how much of value is the entire last sentence, and I would remove it. But, what is even the normalized complexity mesure? In entropy this is clearly defined: the value of the entropy divided by the maximum possible value for the given estimator. Isn't it the same here? If so, maybe just say this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
That makes sense.
Given that there are many different concepts that fall under the umbrella "complexity measure", there's no way - like for entropy - to know how one would like to normalize it. It would be method-specific. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See my latest commit for a suggestion on an improve docstrings. |
||||||
""" | ||||||
function complexity_normalized end | ||||||
|
||||||
include("complexity_measures/complexity_measures.jl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complexity is the name of a scientific field (the study of complex systems).