Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More encodings #299
More encodings #299
Changes from 43 commits
965b9df
e45cb1d
107d5ca
5b0c7f5
c25997b
72f4090
43049af
d1e745a
a86102a
baec12b
81b6e10
84d3956
baa44d7
4f909ae
24b4b38
ee892be
e11d46d
4c30e78
c4e7548
481b1bc
fa7ff8f
d8079ca
3255acf
3a045ad
394d618
66207ed
bfb9403
605f603
0a12e38
e7a9606
f459bdb
b3df322
1801107
c6002b8
f533cf0
ef6c46a
67e93d5
d55bf58
714d869
45b6031
d74a71b
a872497
1955f50
cb04fad
eb12867
4c3f65f
ce071b2
42ab904
1c9aab6
d42dedd
c82e746
3a44f7d
e8cd945
58802bf
1d1fba0
c7d6d96
6c5365a
8ae7157
ad13c9b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar as above, don't make a vector, use
map
so that a tuple is created.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I get this comment.
map
ping anything returns a vector:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
map
only returns a vector if the collection is a vector. If its a tuple it returns a tuplke and doesnt allocate anything:so
encodings
must be atuple.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, a tuple is equivalent with the cartesian indices, so we also reduce computations when converting.
Check warning on line 130 in src/encoding_implementations/gaussian_cdf.jl
Codecov / codecov/patch
src/encoding_implementations/gaussian_cdf.jl#L128-L130
Check warning on line 64 in src/encoding_implementations/ordinal_pattern.jl
Codecov / codecov/patch
src/encoding_implementations/ordinal_pattern.jl#L63-L64