Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement TrackedResource #94

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

implement TrackedResource #94

wants to merge 3 commits into from

Conversation

Krastanov
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #94 (efd437c) into master (bb72add) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   98.20%   98.42%   +0.22%     
==========================================
  Files          10       11       +1     
  Lines         278      318      +40     
==========================================
+ Hits          273      313      +40     
  Misses          5        5              
Files Changed Coverage Δ
src/ConcurrentSim.jl 100.00% <ø> (ø)
src/resources/tracked.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Krastanov
Copy link
Member Author

Fixes #80 -- at least as a rudimentary first step, but other future functionality would be nice to add as well.

@hdavid16 , I added a Tables.jl interface with the idea that the tables converter can take care of providing more detailed data in the future without causing breaking changes to the API.

E.g. we might start tracking exact occupancy by adding a column to the table. We can change the internal storage to make it more efficient without changing the tables interface.

Currently the idea is to keep the internal storage as simple as possible, but maybe add some postprocessing steps in the tables converter.

Let me know if you prefer any of this do be done differently. Let me know if you prefer a different name for the new resource wrapper.

@Krastanov Krastanov linked an issue Aug 3, 2023 that may be closed by this pull request
3 tasks
@Krastanov
Copy link
Member Author

This currently does not work great with interrupts or channels with latency. I will keep this on hold until I have something nice for those cases.

@Krastanov Krastanov mentioned this pull request Aug 7, 2023
@Krastanov Krastanov marked this pull request as draft June 10, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO: Transparent statistics gathering for resources
2 participants