Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement StackStore and QueueStore #98

Merged
merged 3 commits into from
Aug 7, 2023
Merged

implement StackStore and QueueStore #98

merged 3 commits into from
Aug 7, 2023

Conversation

Krastanov
Copy link
Member

Ordered versions of the Store resource.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #98 (e62228b) into master (c8595c6) will increase coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   98.17%   98.67%   +0.50%     
==========================================
  Files          10       11       +1     
  Lines         274      302      +28     
==========================================
+ Hits          269      298      +29     
+ Misses          5        4       -1     
Files Changed Coverage Δ
src/ConcurrentSim.jl 100.00% <ø> (ø)
src/resources/ordered_stores.jl 100.00% <100.00%> (ø)
src/resources/stores.jl 97.72% <100.00%> (+2.48%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Krastanov
Copy link
Member Author

Krastanov commented Aug 7, 2023

@hdavid16 , this is not redundant, right? I tried to see how else to make Stores with well defined order of items, but it does not seem like there is a way to do that right now. The implementation here is pretty simple and fully tested, so hopefully there are no issues with it.

Copy link
Member

@hdavid16 hdavid16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Good addition.
My only comment is that the Store docstring should be updated: the items are not stored in a FILO stack.

@Krastanov
Copy link
Member Author

good catch! Thank you! Fixed this and will merge a bit later today.

@Krastanov Krastanov merged commit 91c7e36 into master Aug 7, 2023
@Krastanov Krastanov deleted the queue branch June 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants